feat: Add onDiskSize property to FileInfo (Fixes #3650) - #3668
Closed
wasim-builds wants to merge 2 commits into
Closed
feat: Add onDiskSize property to FileInfo (Fixes #3650)#3668wasim-builds wants to merge 2 commits into
wasim-builds wants to merge 2 commits into
Conversation
Contributor
|
Closing as there's already an open PR for this: #3656 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @weissi! 👋
As discussed in #3650, I've added the
.onDiskSizeproperty toFileInfoto accurately report the actual size used on disk (accounting for holes in sparse files and APFS compression).Implementation Details:
Int64(platformSpecificStatus.st_blocks) * 512for POSIX systems (Linux/Darwin) using the POSIX standard block size of 512 bytes.nilon Windows wherest_blocksis unavailable.FileInfoTests.swiftverifying the block multiplication.onDiskSize: Int64? = nil) to ensure we do not break the existing public API.All unit tests are passing locally. Let me know if you'd like any modifications, otherwise this should be good to merge! 🚀