feat: Add unchecked variants to NIOLoopBound(Box) - #3678
Open
wasim-builds wants to merge 4 commits into
Open
Conversation
Lukasa
reviewed
Jul 22, 2026
| /// | ||
| /// - Note: This is an unchecked variant of ``init(_:eventLoop:)`` that only asserts in debug mode. | ||
| @inlinable | ||
| public init(unchecked value: Value, eventLoop: EventLoop) { |
Contributor
There was a problem hiding this comment.
Let's make these names a bit more explicit about what we're not checking, e.g.
Suggested change
| public init(unchecked value: Value, eventLoop: EventLoop) { | |
| public init(uncheckedOnEventLoop value: Value, eventLoop: EventLoop) { |
Contributor
There was a problem hiding this comment.
I might also suggest we call these uncheckedUnsafe to clarify what's happening.
Contributor
Author
|
Thanks @Lukasa for the review! I've updated the initializer parameter label and properties to use |
Address review feedback from Lukasa: the init parameter should be 'uncheckedOnEventLoop' to clarify what specifically is unchecked (the event loop assertion), not 'uncheckedUnsafe' which better describes the property/method accessors.
Contributor
Author
|
Thanks @Lukasa! Applied both pieces of feedback:
Branch has been updated. |
Contributor
Author
|
By the way, I've really been enjoying contributing to this project! My goal is to get more involved in open source to help maintain projects and learn from great engineering teams. Is there a process or pathway for becoming a member of the apple GitHub organization? I'd love to continue helping out where I can! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2506