Skip to content

Update MessageSet Parsing #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
+10,022 −9,495
Merged

Update MessageSet Parsing #1754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c45be7
Update MessageSet decoding to only take the first values.
thomasvl Feb 11, 2025
f9aa3f0
Add a new proto definition to use in tests and regenerate.
thomasvl Feb 11, 2025
9254608
Add tests for the new behaviors
thomasvl Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,185 changes: 593 additions & 592 deletions Protos/SwiftProtobufTests/generated_swift_names_enum_cases.proto
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions Protos/SwiftProtobufTests/generated_swift_names_enums.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ message GeneratedSwiftReservedEnums {
enum Google_Protobuf_UninterpretedOption { NONE_Google_Protobuf_UninterpretedOption = 0; }
enum Google_Protobuf_Value { NONE_Google_Protobuf_Value = 0; }
enum goPackage { NONE_goPackage = 0; }
enum gotData { NONE_gotData = 0; }
enum group { NONE_group = 0; }
enum groupFieldNumberStack { NONE_groupFieldNumberStack = 0; }
enum groupSize { NONE_groupSize = 0; }
Expand Down
Loading
Loading