Textformat reserved #1774
Merged
Textformat reserved #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
force-pushed
the
textformat_reserved
branch
3 times, most recently
from
c9d6a12 to
a1e486d
Compare
Collaborator
Author
|
Ok, this should be good to go. I've broken it down into a sequence of commits to try and make review easier so you can skip some of the generation related ones that otherwise would pretty noisy. |
allevato
reviewed
May 12, 2025
allevato
approved these changes
May 12, 2025
Collaborator
Author
|
Also did the trick of sorting/merging ranges that are connecting that we do for extensions. I don't think it's worth exploiting this in the skip case since it won't be common, mostly doing this because it could make the generated data smaller since it means we can merge the ranges. |
thomasvl
force-pushed
the
textformat_reserved
branch
2 times, most recently
from
c4adb65 to
146e690
Compare
allevato
approved these changes
May 12, 2025
Collaborator
Author
|
Fixes #1771 |
thomasvl
force-pushed
the
textformat_reserved
branch
from
146e690 to
149e38a
Compare
Collaborator
Author
|
@tbkka any chance you can take a look since most of the TextFormat support and |
The spec calls for this, so just building out the matching support. - Update `_NameMap` to track reserved numbers and names and check if a value is reserved. - Update `TextFormatScanner` to skip reserved numbers/names.
Also clear `text_format_failure_list_swift.txt` as the tests now pass with the additional data.
Factor the code out of the extension range code so it can be used also for the reserved fields. This won't really make an performance difference, but by merging them the generate data could end up being smaller.
Extend the test file to so it also has things to be merged.
thomasvl
force-pushed
the
textformat_reserved
branch
from
149e38a to
1b47f44
Compare
Collaborator
Author
|
fyi - rebased over the CL updating the Swift min version. |
Collaborator
Author
|
@tbkka was that thumbs up a looks good or an i'll try to look? |
gjcairo
reviewed
May 16, 2025
tbkka
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.