Standardize depth enforcement. - #2092
Open
thomasvl wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
@Lukasa @FranzBusch @tbkka - I'm putting this up in draft for thoughts. The Protobuf JSON spec doesn't formally say what counts for depth, but we already had "Struct" and "List" counting, "Value" is the potential gap here. Since this would have impact on things that current parse, but could be dangerous, I'm not sure if we should change things, or just let it go. Thoughts? |
thomasvl
force-pushed
the
json_depth_enforcement
branch
from
June 5, 2026 14:45
5137862 to
9bf0795
Compare
Member
|
Looks in general fine to me. |
Collaborator
Author
Use `defer` to avoid accidentally missing a call on a `return` path. This also counts "Value" as an object; that effectively halves the depth of some raw JSON parsed into a "Struct", but it was allowing what might be a stack bomb attempt to be parsed in some cases.
thomasvl
force-pushed
the
json_depth_enforcement
branch
from
July 8, 2026 18:15
9bf0795 to
19c57c6
Compare
thomasvl
marked this pull request as ready for review
August 5, 2026 16:26
thomasvl
enabled auto-merge (squash)
August 5, 2026 16:27
Collaborator
Author
|
@Lukasa ok to land? Please a look at my first comment about the one concern I had. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
deferto avoid accidentally missing a call on areturnpath.This also counts "Value" as an object; that effectively halves the depth of some raw JSON parsed into a "Struct", but it was allowing what might be a stack bomb attempt to be parsed in some cases.