Added support for temporal cloud via api key #29
+55
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// requests to the Temporal server. This provides an alternative to mTLS certificate authentication | ||
| /// for Temporal Cloud deployments. | ||
| /// | ||
| /// If both an API key and mTLS certificates are configured, the API key takes precedence for |
There was a problem hiding this comment.
I’m not sure if “takes precedence” is the right wording here, since both transport security and the API key are configured, I assume Temporal Cloud simply prioritizes authentication via the API key?
| instrumentation: Instrumentation, | ||
| namespace: String = "default", | ||
| identity: String? = nil, | ||
| apiKey: String? = nil, |
There was a problem hiding this comment.
Note that this key can only be set once and cannot be updated anymore after that, in contrast to the C# SDK: https://github.com/temporalio/sdk-dotnet/blob/75baab835682b7ea7bc87b3bc225c8b0526b33da/src/Temporalio/Client/TemporalConnection.cs#L98
There was a problem hiding this comment.
| /// requests to the Temporal server. This provides an alternative to mTLS certificate authentication | ||
| /// for Temporal Cloud deployments. | ||
| /// | ||
| /// If both an API key and mTLS certificates are configured, the API key takes precedence for |
|
Also some tests seem to fail constantly with that change: https://github.com/apple/swift-temporal-sdk/actions/runs/18418846103/job/52488729769?pr=29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added support for API Keys for temporal cloud.