-
-
Notifications
You must be signed in to change notification settings - Fork 864
add request logs for iOS:APNS and Android:FCM #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you check this PR? @appleboy |
I fixed lint errors |
@@ -358,7 +359,15 @@ func GetIOSNotification(req PushNotification) *apns2.Notification { | |||
|
|||
notification.Payload = payload | |||
|
|||
return notification | |||
jsonMarshall, err := json.Marshal(notification) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a flag to enable or disable showing the debug message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, I will check it out
Hi @keremoge! Could you explain please why we need to see apns\fcm message in logs? Is it still actual for you? |
Hi, because inn gorush you can track the log of gorush request but not the request going to Notification Servers.
|
@keremoge makes sense! Thank you. Can you please update your PR? Now we have conflicts here |
I resolved conflicts on vsCode but still has conflict warnings |
Should I need to make new PR? |
@keremoge I think so. Please close this PR and create a new one. Thank you! |
reopened this PR as #639 |
Apns and FCM Api logs added to see which requests are going to Apns And Fcm servers