Skip to content

Activate thin snapshot after creation with lvchange -K -ay#10

Merged
guifranchi merged 1 commit into
mainfrom
fix/activate-thin-snapshot-after-creation
May 20, 2026
Merged

Activate thin snapshot after creation with lvchange -K -ay#10
guifranchi merged 1 commit into
mainfrom
fix/activate-thin-snapshot-after-creation

Conversation

@guifranchi

Copy link
Copy Markdown
Contributor

Summary

  • Thin LV snapshots are created with the "skip activation" flag (k) set by default on the LVM version running on ci-hel3 (Ubuntu 22.04)
  • lvchange -ay silently respects that flag and does nothing — no DM device is ever created, /dev/<vg>/<lv> never appears, and mount fails with ENOENT (exit 32)
  • Adds lvchange -K -ay (--ignoreactivationskip) immediately after lvcreate -s, followed by udevadm settle to ensure the /dev symlink is present before returning

Manually confirmed on ci-hel3:

# lvchange -K -ay runners/rootfs-default-0
# ls -la /dev/runners/rootfs-default-0
lrwxrwxrwx 1 root root 7 ... /dev/runners/rootfs-default-0 -> ../dm-5
# mount /dev/runners/rootfs-default-0 /tmp/test-mnt && echo "MOUNT OK"
MOUNT OK

Test plan

  • Review and merge
  • Create release v0.1.8
  • Bump ci_actions_runner_manager_version to 0.1.8 in ansible and deploy to ci-hel3
  • Confirm boot cycles progress past the mount step and Firecracker VMs start

🤖 Generated with Claude Code

Thin LV snapshots are created with the "skip activation" flag (k) set by
default on this LVM version. lvchange -ay silently respects that flag and
does nothing, so no DM device is created and /dev/<vg>/<lv> never appears.

Add lvchange -K -ay (--ignoreactivationskip) after lvcreate -s to force
activation, followed by udevadm settle to ensure the /dev symlink exists
before returning to callers.

Confirmed manually on ci-hel3: lvchange -K -ay runners/rootfs-default-0
produced the device node and a subsequent mount succeeded.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@backlog-helper

backlog-helper Bot commented May 20, 2026

Copy link
Copy Markdown

Hi @guifranchi,

We've found some issues with your Pull Request.

  • This Pull Request is missing reviewers. Either convert this Pull Request into a draft or ignore this rule by adding [skip review] to your Pull Request body. - (More info)

New issue guide | Backlog management | Rules | Feedback

@guifranchi guifranchi added the bug label May 20, 2026
@guifranchi
guifranchi merged commit a03c5b3 into main May 20, 2026
1 check passed
@guifranchi
guifranchi deleted the fix/activate-thin-snapshot-after-creation branch May 20, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant