Activate thin snapshot after creation with lvchange -K -ay#10
Merged
Conversation
Thin LV snapshots are created with the "skip activation" flag (k) set by default on this LVM version. lvchange -ay silently respects that flag and does nothing, so no DM device is created and /dev/<vg>/<lv> never appears. Add lvchange -K -ay (--ignoreactivationskip) after lvcreate -s to force activation, followed by udevadm settle to ensure the /dev symlink exists before returning to callers. Confirmed manually on ci-hel3: lvchange -K -ay runners/rootfs-default-0 produced the device node and a subsequent mount succeeded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @guifranchi, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
k) set by default on the LVM version running on ci-hel3 (Ubuntu 22.04)lvchange -aysilently respects that flag and does nothing — no DM device is ever created,/dev/<vg>/<lv>never appears, andmountfails with ENOENT (exit 32)lvchange -K -ay(--ignoreactivationskip) immediately afterlvcreate -s, followed byudevadm settleto ensure the/devsymlink is present before returningManually confirmed on ci-hel3:
Test plan
v0.1.8ci_actions_runner_manager_versionto0.1.8in ansible and deploy to ci-hel3🤖 Generated with Claude Code