Pass LVM config to Instance on construction#8
Merged
Conversation
Instance::new() initialises lvm with empty strings and relies on with_lvm() being called afterwards to populate it from ManagerConfig, but with_lvm() was never called. As a result, lvcreate was invoked with an empty volume group, producing paths like "/base-default" instead of "runners/base-default", causing all slot boot cycles to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matsimitsu
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instance::new()initialises itslvmfield with empty strings and has awith_lvm()builder method intended to populate it fromManagerConfigwith_lvm()was never called at the construction site inslot.rslvcreatewas invoked with an empty volume group, producing paths like/base-defaultinstead ofrunners/base-default, causing every slot boot cycle to fail with:Fix
Chain
.with_lvm(&config.lvm)onto theInstance::new()call inrun_slot().Test plan
journalctl -u actions-runner