Skip to content

Pass LVM config to Instance on construction#8

Merged
guifranchi merged 1 commit into
mainfrom
fix/lvm-config-not-passed-to-instance
May 20, 2026
Merged

Pass LVM config to Instance on construction#8
guifranchi merged 1 commit into
mainfrom
fix/lvm-config-not-passed-to-instance

Conversation

@guifranchi

@guifranchi guifranchi commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Instance::new() initialises its lvm field with empty strings and has a with_lvm() builder method intended to populate it from ManagerConfig
  • with_lvm() was never called at the construction site in slot.rs
  • As a result, lvcreate was invoked with an empty volume group, producing paths like /base-default instead of runners/base-default, causing every slot boot cycle to fail with:
    "/rootfs-default-0": Invalid path for Logical Volume.
    Volume group name  has invalid characters
    lvcreate snapshot failed: /base-default -> rootfs-default-0
    

Fix

Chain .with_lvm(&config.lvm) onto the Instance::new() call in run_slot().

Test plan

  • Build and release a new version
  • Deploy to ci-hel3 (staging manager node) and verify boot cycles succeed in journalctl -u actions-runner

Instance::new() initialises lvm with empty strings and relies on
with_lvm() being called afterwards to populate it from ManagerConfig,
but with_lvm() was never called. As a result, lvcreate was invoked
with an empty volume group, producing paths like "/base-default"
instead of "runners/base-default", causing all slot boot cycles to fail.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@guifranchi guifranchi self-assigned this May 19, 2026
@guifranchi guifranchi added the bug label May 19, 2026
@guifranchi
guifranchi requested a review from matsimitsu May 19, 2026 21:33
@guifranchi
guifranchi merged commit 93423f9 into main May 20, 2026
1 check passed
@guifranchi
guifranchi deleted the fix/lvm-config-not-passed-to-instance branch May 20, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants