Wait for udev to settle after thin snapshot creation#9
Merged
Conversation
After lvcreate -s succeeds the kernel fires a uevent, but the /dev/<vg>/<lv> device node is created asynchronously by udevd. Mounting the device immediately after lvcreate can race against udev and fail with ENOENT. Adding udevadm settle --timeout=5 ensures the device node exists before returning control to callers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @guifranchi, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lvcreate -ssucceeds the kernel fires a uevent, but the/dev/<vg>/<lv>device node is created asynchronously by udevdlvcreate_snapshotraces against udev, producingspecial device /dev/runners/rootfs-default-X does not exist(exit status 32)udevadm settle --timeout=5insidelvcreate_snapshotso the device node is guaranteed to exist before returning to callers