Add support for Phoenix 1.8's parameter filtering #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Phoenix 1.18 the parameter filtering now uses compiled patterns. Update our implementation with the new Phoenix implementation so we can support both Phoenix 1.18 and newer, and older versions. We do this by checking if the value in `Application.get_env(:phoenix, :filter_parameters, [])` is a compiled pattern. Relevant commit in Phoenix: phoenixframework/phoenix@359539f
tombruijn
added
the
bug
tombruijn
changed the title
unflxw
approved these changes
Jul 21, 2025
Comment on lines
+38
to
+42
| is_binary(k) and String.contains?(k, key_match) -> | ||
| {k, "[FILTERED]"} | ||
|
|
||
| is_binary(v) and String.contains?(v, value_match) -> | ||
| {k, "[FILTERED]"} |
There was a problem hiding this comment.
Took me a second to square how we use it (with String.contains?/2) with the reported shape of the error in the original issue. Turns out this is the :binary.cp() data type from Erlang, representing a pattern to match against. TIL!
Vitaly-A-Ivanov
pushed a commit
to spacebetween/appsignal-elixir
that referenced
this pull request
Sep 3, 2025
In Phoenix 1.8 the parameter filtering now uses compiled patterns. Update our implementation with the new Phoenix implementation so we can support both Phoenix 1.8 and newer, and older versions. We do this by checking if the value in `Application.get_env(:phoenix, :filter_parameters, [])` is a compiled pattern. Relevant commit in Phoenix: phoenixframework/phoenix@359539f (cherry picked from commit 1449b9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Phoenix 1.8 the parameter filtering now uses compiled patterns. Update our implementation with the new Phoenix implementation so we can support both Phoenix 1.8 and newer, and older versions. We do this by checking if the value in
Application.get_env(:phoenix, :filter_parameters, [])is a compiled pattern.Relevant commit in Phoenix: phoenixframework/phoenix@359539f
Fixes #1008