Fix compilation on Elixir main #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the `do end` block no longer works for `catch_exit`. The only thing it seems to do is catch an exit if one occurs, not assert if it happens. If we remove it the tests fails on the errors we assert on the spans that bubble up from the GenServer. Directly pass in the GenServer call, like in the docs example: ```elixir assert catch_exit(exit(1)) == 1 ``` https://hexdocs.pm/ex_unit/ExUnit.Assertions.html#catch_exit/1
|
This is a message from the daily scheduled checks. |
unflxw
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
do endblock no longer works forcatch_exit.The only thing it seems to do is catch an exit if one occurs, not assert if it happens. If we remove it the tests fails on the errors we assert on the spans that bubble up from the GenServer.
Directly pass in the GenServer call, like in the docs example:
https://hexdocs.pm/ex_unit/ExUnit.Assertions.html#catch_exit/1
[skip changeset]