Use parentheses when accessing Tesla's __middleware__/0
#968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warning when compiling against Elixir 1.17.x: ``` warning: using map.field notation (without parentheses) to invoke function [...].Client.__middleware__() is deprecated, you must add parentheses instead: remote.function() (appsignal 2.13.0) lib/appsignal/tesla.ex:113: Appsignal.Tesla.module_middlewares/1 (appsignal 2.13.0) lib/appsignal/tesla.ex:106: Appsignal.Tesla.env_middlewares/1 (appsignal 2.13.0) lib/appsignal/tesla.ex:45: Appsignal.Tesla.do_tesla_request_start/2 (telemetry 1.3.0) [...]/elixir/deps/telemetry/src/telemetry.erl:167: anonymous fn/4 in :telemetry.execute/3 (stdlib 6.1.2) lists.erl:2310: :lists.foreach_1/2 (tesla 1.12.1) lib/tesla/middleware/telemetry.ex:96: Tesla.Middleware.Telemetry.call/3 (appsignal 2.13.0) lib/appsignal/instrumentation.ex:10: Appsignal.Instrumentation.instrument/1 ```
tombruijn
approved these changes
Oct 25, 2024
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is a message from the daily scheduled checks. |
See previous commit for the change. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following warning when compiling against Elixir 1.17.x: