Add support for OTP 28 #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismiramirez
force-pushed
the
otp-27-support
branch
4 times, most recently
from
01e1bff to
4222c47
Compare
|
Failures on CI when using OTP28 are expected. Here's the issue that tracks the problem: hexpm/hex#1065 Pausing until fixed. It's OK as OTP28 isn't fully released yet. |
This is a message from the daily scheduled checks. |
tombruijn
force-pushed
the
otp-27-support
branch
4 times, most recently
from
cc89ec1 to
88f7e10
Compare
Add OTP 28 and Elixir 1.18.x to the CI matrix.
tombruijn
force-pushed
the
otp-27-support
branch
from
88f7e10 to
eb2c514
Compare
The regular expressions would lead to compile errors when the tests ran.
This is because the `-` in square brackets indicate a range.
I guess on newer Elixir versions they're more strict on this.
```
** (Regex.CompileError) invalid range in character class at position 7
code: assert %{"level" => "DEBUG", "message" => "debug!"} = match_file_format(output)
stacktrace:
(elixir 1.18.4) lib/regex.ex:254: Regex.compile!/2
test/appsignal/integration_logger_test.exs:167: Appsignal.IntegrationLoggerTest.match_file_format/1
test/appsignal/integration_logger_test.exs:74: (test)
```
tombruijn
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OTP 28 and Elixir 1.18.x to the CI matrix.
[skip changeset]
Closes #998