Report top-level owners for pods#56
Merged
Merged
Conversation
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
force-pushed
the
add-owner-references
branch
4 times, most recently
from
July 14, 2025 09:44
753121b to
7e1e3dd
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This is a message from the daily scheduled checks. |
tombruijn
approved these changes
Jul 17, 2025
tombruijn
left a comment
tombruijn
left a comment
Member
There was a problem hiding this comment.
Don't forget to add a changeset.
unflxw
added a commit
that referenced
this pull request
Jul 17, 2025
There's something broken with the existing logic for updating the Helm chart. It will be fixed as part of #56, but in the meantime this commit updates it manually.
For each pod, report the top-level owner resources for those pods, that is, the transitive owners which are not owned by any other resources. Note that a pod may have more than one owner, and therefore it can also have more than one top-level owner. Update the `kube` crate to version 1.1.0 and the `k8s-openapi` crate to version `0.25.0`. Use the "earliest" feature instead of "latest" to support most API server versions, though there is no significant difference in support regardless. Update the Rust version to 1.82.0 to be able to use a recent version of the `kube` crate. Implement a cache for ownership resolution and API discovery. The discovery results are kept between runs, but can be refreshed if resources from new APIs are referenced. The ownership cache is reset during each run, as the ownership relationships can change at any time. Improve trace logging. Do not `panic!` when AppSignal or Kubernetes are unreachable. Update the deployment YAML to provide read-only permissions to all API groups and resources -- this is necessary due to the owner traversal logic needing to be able to retrieve arbitrary resources. Update the deployment YAML for Helm as well, and fix the version updating script to update the version number on it as well.
unflxw
force-pushed
the
add-owner-references
branch
from
July 17, 2025 16:47
7e1e3dd to
6aeaf5c
Compare
unflxw
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53. See protocol change at https://github.com/appsignal/appsignal-protocol/pull/125.
For each pod, report the top-level owner resources for those pods, that is, the transitive owners which are not owned by any other resources. Note that a pod may have more than one owner, and therefore it can also have more than one top-level owner.
Update the
kubecrate to version 1.1.0 and thek8s-openapicrate to version0.25.0. Use the "earliest" feature instead of "latest" to support most API server versions, though there is no significant difference in support regardless.Update the Rust version to 1.82.0 to be able to use a recent version of the
kubecrate.Implement a cache for ownership resolution and API discovery. The discovery results are kept between runs, but can be refreshed if resources from new APIs are referenced. The ownership cache is reset during each run, as the ownership relationships can change at any time.
Improve trace logging. Do not
panic!when AppSignal or Kubernetes are unreachable.Update the deployment YAML to provide read-only permissions to all
API groups and resources -- this is necessary due to the owner
traversal logic needing to be able to retrieve arbitrary resources.
Update the deployment YAML for Helm as well, and fix the version
updating script to update the version number on it as well.