Conversation
Our existing Helm chart is just a copy and paste of the existing `deployment.yaml` for `kubectl`, with some unrelated broken files alongside it. Replace this with templates that actually interpolate the values in the chart. Rather than having the release process copy-paste the `deployment.yaml` from the root into the chart, do the opposite: use Helm's template as the source of truth to generate `deployment.yaml` from.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
|
This also changes |
It's probably not possible to warn people this will happen, right? Other than a note in the changelog. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This is a message from the daily scheduled checks. |
Our existing Helm chart is just a copy and paste of the existing
deployment.yamlforkubectl, with some unrelated broken files alongside it.Replace this with templates that actually interpolate the values in the chart. Rather than having the release process copy-paste the
deployment.yamlfrom the root into the chart, do the opposite: use Helm's template as the source of truth to generatedeployment.yamlfrom.Fixes #59.
To do
README.mdchanges)