Skip to content

Implement an actual Helm chart#60

Merged
unflxw merged 1 commit into
mainfrom
fix-helm
Jul 23, 2025
Merged

Implement an actual Helm chart#60
unflxw merged 1 commit into
mainfrom
fix-helm

Conversation

@unflxw

@unflxw unflxw commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Our existing Helm chart is just a copy and paste of the existing deployment.yaml for kubectl, with some unrelated broken files alongside it.

Replace this with templates that actually interpolate the values in the chart. Rather than having the release process copy-paste the deployment.yaml from the root into the chart, do the opposite: use Helm's template as the source of truth to generate deployment.yaml from.

Fixes #59.

To do

  • Update docs for Helm (see README.md changes)

Our existing Helm chart is just a copy and paste of the existing
`deployment.yaml` for `kubectl`, with some unrelated broken files
alongside it.

Replace this with templates that actually interpolate the values in
the chart. Rather than having the release process copy-paste the
`deployment.yaml` from the root into the chart, do the opposite: use
Helm's template as the source of truth to generate `deployment.yaml`
from.
@unflxw
unflxw requested a review from tombruijn July 18, 2025 10:58
@unflxw unflxw self-assigned this Jul 18, 2025
@unflxw unflxw added the chore A small task that takes a day or two at the most. label Jul 18, 2025
@backlog-helper

Copy link
Copy Markdown

Hi @unflxw,

We've found some issues with your Pull Request.

  • This Pull Request does not include a changeset. Add a changeset if the change impacts users and should be included in the changelog upon release. Read more about changesets.
    Ignore this rule by adding [skip changeset] to your Pull Request body. - (More info)

New issue guide | Backlog management | Rules | Feedback

@unflxw

unflxw commented Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

This also changes deployment.yaml and the Helm installation instructions to install it in the appsignal namespace. I think this is a good idea, and shouldn't affect functioning since it's got permissions to all namespaces, but it is a breaking change for people who already installed it (re-applying will create a second set of AppSignal for Kubernetes pods and resources)

@tombruijn

tombruijn commented Jul 21, 2025

Copy link
Copy Markdown
Member

This also changes deployment.yaml and the Helm installation instructions to install it in the appsignal namespace. I think this is a good idea, and shouldn't affect functioning since it's got permissions to all namespaces, but it is a breaking change for people who already installed it (re-applying will create a second set of AppSignal for Kubernetes pods and resources)

It's probably not possible to warn people this will happen, right? Other than a note in the changelog.

Comment thread charts/appsignal-kubernetes/templates/deployment.yaml
@backlog-helper

This comment has been minimized.

1 similar comment
@backlog-helper

Copy link
Copy Markdown

This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

@unflxw
unflxw merged commit d75e05a into main Jul 23, 2025
3 checks passed
unflxw added a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A small task that takes a day or two at the most.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm install in custom namespace

2 participants