Fix namespace creation in Helm #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
added
the
bug
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
force-pushed
the
fix-namespace-helm
branch
from
5966c76 to
0f49c50
Compare
The Helm chart included a `namespace.yaml` definition, which was useful so that the `deployment.yaml` generated from the Helm chart would contain a namespace. However, this breaks Helm's `--namespace` and `--create-namespace` flags, which are the preferred way to install a Helm chart on a specific namespace, and are what we recommend on our README. Turn the existing `managed` flag into a `kubectl` flag that determines whether we're compiling the Helm template to be used via `kubectl`. This flag is off in the default values, but when it's on, it will cause the namespace to be present and remove Helm-related labels.
unflxw
force-pushed
the
fix-namespace-helm
branch
from
0f49c50 to
93d38a8
Compare
tombruijn
approved these changes
Jul 24, 2025
|
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Intercom conversation for context.
The Helm chart included a
namespace.yamldefinition, which was useful so that thedeployment.yamlgenerated from the Helm chart would contain a namespace. However, this breaks Helm's--namespaceand--create-namespaceflags, which are the preferred way to install a Helm chart on a specific namespace, and are what we recommend on our README.Turn the existing
managedflag into akubectlflag that determines whether we're compiling the Helm template to be used viakubectl. This flag is off in the default values, but when it's on, it will cause the namespace to be present and remove Helm-related labels.