Auto detect log format #1228
Merged
Auto detect log format #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default log format from 'plaintext' to 'autodetect'. Our processor will automatically try to detect the correct log format, which should create a better experience than the default being plaintext. Part of appsignal/integration-guide#174
lipskis
reviewed
Sep 26, 2025
lipskis
approved these changes
Sep 26, 2025
The autodetect format is the default, update the test name to match. [skip ci]
This is the API our customers use, also default it to the autodetect format.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This is a message from the daily scheduled checks. |
unflxw
reviewed
Sep 30, 2025
There was a problem hiding this comment.
Looks good so far. Also needs to be updated in the Pino and Winston transports:
- https://github.com/appsignal/appsignal-nodejs/blob/main/src/pino_transport.ts#L33
- https://github.com/appsignal/appsignal-nodejs/blob/main/src/winston_transport.ts#L79
Like in the Ruby PR: has the agent been updated here as well?
Yes. It's been updated in #1227 |
Update the default format to the autodetect format as well.
|
I've updated the Pino and Winston transports. I saw no tests for the Pino transport, so I made an issue here: #1243 |
unflxw
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default log format from 'plaintext' to 'autodetect'. Our processor will automatically try to detect the correct log format, which should create a better experience than the default being plaintext.
Part of https://github.com/appsignal/integration-guide/issues/174