Make config env, root path and options read only #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do like the actual apps that use AppSignal and don't modify the config after it's initialized. Set the config options using the `build_config` helper instead.
The attribute docs were out of date and didn't cover all the attributes. Instead give them the same docs for all source attributes.
Not sure why these were an accessor, but they don't need to define writers to allow app to overwrite the config after AppSignal has started. That can cause problems and expectations that the changed config is picked up. [skip changeset] as these are private APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor specs to not modify config after init
Do like the actual apps that use AppSignal and don't modify the config after it's initialized. Set the config options using the
build_confighelper instead.Improve docs for config sources API
The attribute docs were out of date and didn't cover all the attributes. Instead give them the same docs for all source attributes.
Make config env, root path and options read only
Not sure why these were an accessor, but they don't need to define writers to allow app to overwrite the config after AppSignal has started. That can cause problems and expectations that the changed config is picked up.
[skip changeset] as these are private APIs.
[skip review]