Fix session data for Action Cable callbacks #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In issue #1313 it was reported that session data was not reported for Action Cable callbacks. This broke after PR #1209 where we changed the way we handle sample data by allowing merging, which required more strict type checks. By calling `to_h`, ensure the value is a Hash, which is a valid sample data type. Fixes #1313
tombruijn
added
the
bug
This only changes one word in the changeset and can be squashed in the history. [skip ci]
luismiramirez
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #1313 it was reported that session data was not reported for Action Cable callbacks. This broke after PR #1209 where we changed the way we handle sample data by allowing merging, which required more strict type checks.
By calling
to_h, ensure the value is a Hash, which is a valid sample data type.Fixes #1313