Test if the AppSignal middleware isn't added #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only asserted what happened the first time the app was initialized, because it remained stored on the MyApp constant. So we were testing a static value. This update tests the actual middleware that get added to the stack.
Test the change that doesn't add the middleware to the app if AppSignal is not active and the `start_at` is `on_load` (the default). [skip changeset]
unflxw
approved these changes
Aug 28, 2025
unflxw
merged commit 105511a
into
only-instrument-rails-if-appsignal-started
187 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix middleware assertion in Railtie spec
It only asserted what happened the first time the app was initialized, because it remained stored on the MyApp constant. So we were testing a static value.
This update tests the actual middleware that get added to the stack.
Test if the AppSignal middleware isn't added
Test the change that doesn't add the middleware to the app if AppSignal is not active and the
start_atison_load(the default).[skip changeset]
Based on #1444