Truncate internal log lines #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
added
the
bug
|
Build failures are unrelated because they also happen on the main branch. |
Truncate logs sent to our internal integrations logger. We had a report that for a `ActionController::BadRequest` error the appsignal.log file filled up with the uploaded file, as it's part of the error message. This will limit the log line length to 2000 characters. We can increase this if needed. Closes appsignal/support#364
tombruijn
force-pushed
the
truncate-logs
branch
from
72c4842 to
5374088
Compare
lipskis
approved these changes
Oct 16, 2025
.changesets/do-not-log-long-error-messages-to-internal-appsignal-log.md
Outdated
Show resolved
Hide resolved
Change truncate to truncated in the changeset. [skip ci] Co-authored-by: Martin Lipskis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate logs sent to our internal integrations logger.
We had a report that for a
ActionController::BadRequesterror the appsignal.log file filled up with the uploaded file, as it's part of the error message.This will limit the log line length to 2000 characters. We can increase this if needed.
Closes https://github.com/appsignal/support/issues/364