Support CodeOwnership 2.0.0 #1474
Open
+40
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from version `2.0.0` of `CodeOwnership` teams that don't have a `github` property in their `team.yml` config file are ignored. Add github property with fake github organizations to all team config fixtures.
lipskis
force-pushed
the
support-codeownership2
branch
from
23bbb18 to
40d5f7e
Compare
lipskis
force-pushed
the
support-codeownership2
branch
from
40d5f7e to
ad0dff6
Compare
Starting from version `2.0.0` `CodeOwnership` is much stricter in how it handles config. Files that aren't included in `owned_globs` of `config/code_ownership.yml` are ignored even if valid ownership is specified. This broke the existing setup for integration tests. Move all "app" fixtures to `/app` directory. Copy all config and app files from `support_dir` to `tmp_dir`, so that everything is loaded from same directory.
The public api method that the integration uses hasn't changed. Remove requirement for `CodeOwnership` gem version below `v2.0`.
lipskis
force-pushed
the
support-codeownership2
branch
from
1e35984 to
1b6af50
Compare
The CodeOwnership gem fails to build its native extension on ruby `3.5.0-preview1`. Remove ruby `3.5.0-preview1` from the CodeOwnership gem's CI build matrix.
lipskis
force-pushed
the
support-codeownership2
branch
from
1b6af50 to
63dff70
Compare
CodeOwnership uses `oxidize-rb/actions/fetch-ci-data@v1` github action to fetch a list of ruby versions to build native extension for. During the realase of 2.0.0 it only returned ["3.2", "3.4"]. The gem fails to load because there's no compiled native extension available for Ruby 3.3. Missing builds for Ruby 3.3 seems to be a known issue in the `oxidize-rb/actions` repo. See oxidize-rb/actions#62 Remove Ruby 3.3.4 from the build matrix.
lipskis
commented
Oct 24, 2025
Comment on lines
151
to
-168
| def create_team_files | ||
| FileUtils.mkdir(File.join(tmp_dir, "config", "teams")) | ||
|
|
||
| %w[file directory].each do |team| | ||
| FileUtils.copy_file( | ||
| File.join(support_dir, "code_ownership", "config", "teams", "#{team}.yml"), | ||
| File.join(tmp_dir, "config", "teams", "#{team}.yml") | ||
| ) | ||
| end | ||
|
|
||
| glob_team = | ||
| <<~CONFIG | ||
| name: GlobTeam | ||
| owned_globs: | ||
| - #{File.join(support_dir, "code_ownership", "glob", "*.rb")} | ||
| CONFIG | ||
|
|
||
| write_file(File.join(tmp_dir, "config", "teams", "glob.yml"), glob_team) |
There was a problem hiding this comment.
Now that everything is loaded from the same directory, there's no need for a dynamic owned_globs property, so I moved the glob_team config into the config/teams/glob.yml fixture.
This is a message from the daily scheduled checks. |
unflxw
approved these changes
Oct 27, 2025
Yes, it's unrelated. Two things appeared simultaneously on the same day and broke everything:
Once this PR and #1473 are merged, we should be back to green builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes were necessary in the integration. The only issues were stricter config requirements that caused CodeOwnership to ignore teams in our tests.
Fixes #1472.
Add github property to team.yml config files
Starting from version
2.0.0ofCodeOwnershipteams that don'thave a
githubproperty in theirteam.ymlconfig file are ignored.Add github property with fake github organizations to all team config
fixtures.
Move CodeOwnership fixtures to app dir
Starting from version
2.0.0CodeOwnershipis much stricter in how ithandles config. Files that aren't included in
owned_globsofconfig/code_ownership.ymlare ignored even if valid ownership isspecified. This broke the existing setup for integration tests.
Move all "app" fixtures to
/appdirectory. Copy all config and appfiles from
support_dirtotmp_dir, so that everything is loaded fromsame directory.
Remove gem version requirement
The public api method that the integration uses hasn't changed. Remove
requirement for
CodeOwnershipgem version belowv2.0.Update build matrix
The CodeOwnership gem fails to build its native extension on ruby
3.5.0-preview1.Remove ruby
3.5.0-preview1from the CodeOwnership gem's CI buildmatrix.
Disable Ruby 3.3.4 from build matrix
CodeOwnership uses
oxidize-rb/actions/fetch-ci-data@v1github actionto fetch a list of ruby versions to build the native extension for. During
the realase of 2.0.0 it only returned ["3.2", "3.4"]. The gem fails to
load because there's no compiled extension available for Ruby
3.3.
Missing builds for Ruby 3.3 seems to be a known issue in the
oxidize-rb/actionsrepo. Seeoxidize-rb/actions#62
Remove Ruby 3.3.4 from the build matrix.
[skip changeset]