Add Resque 2/3 to build matrix#1519
Merged
Merged
Conversation
Resque 2 was dropped from the matrix in #939, alongside the EOL resque 1. That removal looks accidental: resque 2 was not EOL and its gemfile was left in place when every other removed gem's was deleted. Re-add it so resque 2 is exercised in CI again.
The webmachine 1 build was dropped from CI in #1206, but its gemfile was left behind. Nothing references it anymore, so remove it.
Resque 3.0 was released in January 2026 and requires Ruby 3.0 or newer, so the matrix entry is limited to those versions. The integration spec passes against it unchanged.
unflxw
changed the title
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the CI build matrix to restore Resque 2 coverage, add Resque 3 coverage (limited to Ruby ≥ 3.0), and remove an unused legacy gemfile that’s no longer referenced by the matrix/generator.
Changes:
- Re-add
resque-2to the build matrix so it is exercised in CI again. - Add a new
resque-3gemfile and matrix entry (Ruby 3.0+ only). - Remove the unused
webmachine1gemfile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gemfiles/webmachine1.gemfile | Removes an unused gemfile that is no longer referenced by the CI matrix. |
| gemfiles/resque-3.gemfile | Adds a gemfile to test against Resque 3.x in CI. |
| build_matrix.yml | Updates the build matrix to include resque-2 and resque-3 (with Ruby-version constraints for Resque 3). |
| .github/workflows/ci.yml | Regenerates the GitHub Actions workflow to include the new matrix jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tombruijn
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore resque 2 to the CI build matrix
Resque 2 was dropped from the matrix in #939, alongside the EOL
resque 1. That removal looks accidental: resque 2 was not EOL and
its gemfile was left in place when every other removed gem's was
deleted. Re-add it so resque 2 is exercised in CI again.
Remove the dangling webmachine 1 gemfile
The webmachine 1 build was dropped from CI in #1206, but its gemfile
was left behind. Nothing references it anymore, so remove it.
Add resque 3 to the CI build matrix
Resque 3.0 was released in January 2026 and requires Ruby 3.0 or
newer, so the matrix entry is limited to those versions. The
integration spec passes against it unchanged.