Restore the notifier after AS notifications specs#1529
Merged
Conversation
The ActiveSupport::Notifications specs swap in a fresh notifier to control subscriptions but never restore it, leaking a stale, subscription-less notifier into later specs. Running alphabetically the ActionMailer spec ran first and masked it, but in any order where these run first, ActionMailer's instrumentation fired into the stale notifier and recorded nothing. Restore the original notifier in an around hook. [skip changeset]
|
Hi @unflxw, We've found some issues with your Pull Request.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes cross-spec leakage in the ActiveSupport::Notifications hook specs by ensuring any notifier swap performed for test isolation is reverted after each example, preventing later specs (e.g., ActionMailer instrumentation) from publishing into a stale notifier instance.
Changes:
- Add an
aroundhook that captures the currentActiveSupport::Notifications.notifierbefore the example runs. - Ensure the original notifier is restored in an
ensureblock after the example (even on failures).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ActiveSupport::Notifications specs swap in a fresh notifier to control subscriptions but never restore it, leaking a stale, subscription-less notifier into later specs. Running alphabetically the ActionMailer spec ran first and masked it, but in any order where these run first, ActionMailer's instrumentation fired into the stale notifier and recorded nothing. Restore the original notifier in an around hook.