De-flake the minutely probes thread test#1530
Merged
Merged
Conversation
The test asserted "only one probes thread" by counting every live thread in the process, which drifts when unrelated background threads start or stop mid-example. Assert on the probe thread objects directly instead: the previous thread is killed and replaced by exactly one new live thread. [skip changeset]
|
Hi @unflxw, We've found some issues with your Pull Request.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the probes threading spec to avoid flakiness caused by counting all live threads in the Ruby process. Instead, it asserts directly on the Appsignal::Probes internal thread object to verify that restarting probes replaces the previous thread rather than accumulating multiple running probe threads.
Changes:
- Replace process-wide live-thread counting with direct assertions on the probes thread instance (
@thread). - Add explicit expectations that a second
startreplaces the thread and that the old thread terminates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test asserted "only one probes thread" by counting every live thread in the process, which drifts when unrelated background threads start or stop mid-example. Assert on the probe thread objects directly instead: the previous thread is killed and replaced by exactly one new live thread.