Report grape gem version in environment metadata#1534
Merged
Conversation
Grape is a supported integration (loaded via Appsignal.load(:grape)) but was missing from the SUPPORTED_GEMS list that drives environment gem-version reporting. As a result, Grape apps never reported a ruby_grape_version, making Grape adoption invisible in telemetry (unlike its sibling loader frameworks hanami, sinatra, and padrino, which are all in the list). Add grape so its version is reported like the others. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✔️ All good! |
Contributor
Author
|
@tombruijn I was looking into telemetry to see how many folks are using Grape etc - and Claude flagged that this was missing from the reporting. Please review, apologies if this omission was intentional |
tombruijn
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
grapeto theSUPPORTED_GEMSlist inlib/appsignal/environment.rbso the agent reportsruby_grape_versionin the environment metadata.Why
Grape is a supported integration — it has a loader (
lib/appsignal/loaders/grape.rb,Appsignal.load(:grape)) and dedicatedAppsignal::Rack::GrapeMiddleware. Butgrapewas missing fromSUPPORTED_GEMS, the allowlist thatreport_supported_gemsiterates to emitruby_<gem>_versionenvironment metadata.The practical effect: Grape applications never report a
ruby_grape_version, so Grape adoption and version usage are invisible in our telemetry — even though the integration works. Its three sibling loader-based frameworks (hanami,sinatra,padrino) are all already in the list and report correctly;grapewas simply left out.This was surfaced while analyzing framework adoption across the customer base: Grape came back as "0" purely because of this omission, not because no one uses it.
Change
One entry added to
SUPPORTED_GEMS(alphabetical, betweenfaradayandgvltools), plus a changeset. No behavior change beyond one additional gem version being reported when present in the bundle.Testing
.report_supported_gemsis covered inspec/lib/appsignal/environment_spec.rb; it exercises the mechanism viarack/rakerather than asserting the full list, so no test changes are required.