Expect hostname in Python config #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
force-pushed
the
expect-hostname-python-config
branch
from
735647b to
a0a9023
Compare
As part of the changes to support the collector, the hostname is now part of the system-derived config, rather than left empty and guessed by the agent. Make the diagnose tests happy with that.
unflxw
force-pushed
the
expect-hostname-python-config
branch
from
a0a9023 to
1b26100
Compare
unflxw
force-pushed
the
expect-hostname-python-config
branch
2 times, most recently
from
50a3972 to
f1461bf
Compare
Ruby 3.0 is very much EOL (and won't install in my new laptop) so update to Ruby 3.2. Update Rubocop to a version that has heard of Ruby 3.2, and fix whatever it complains about.
unflxw
force-pushed
the
expect-hostname-python-config
branch
from
f1461bf to
30f1c12
Compare
tombruijn
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See appsignal/appsignal-python#249.
As part of the changes to support the collector, the hostname is now
part of the system-derived config, rather than left empty and guessed
by the agent. Make the diagnose tests happy with that.