Add logging and metrics for Go, Java and PHP #325
Conversation
unflxw
force-pushed
the
logging-metrics-go-java-php
branch
from
17edad5 to
bc89d89
Compare
| // Log different severity levels | ||
| julLogger.info("Application started - java.util.logging"); | ||
| julLogger.log(Level.WARNING, "This is a warning message - java.util.logging"); | ||
| julLogger.severe("This is an error message - java.util.logging"); |
There was a problem hiding this comment.
Cool to see the logging adds the trace and span id. We could use that to link to search.
There was a problem hiding this comment.
Yes! It's not the only one that does it, I believe. I'll create an issue for it. We'll also have to account for the different ways to send this data that exist, because of course they do.
java/spring-agent-collector/app/src/main/java/io/opentelemetry/example/graal/Controller.java
Outdated
Show resolved
Hide resolved
| $gauge->record(10); | ||
|
|
||
| // Histogram metric for distributions (measurements) | ||
| $histogram = $meter->createHistogram('my_histogram'); |
There was a problem hiding this comment.
The histograms are not being reported for (using a locally build collector using the main branch). I get this message:
appsignal-collector-1 | [2025-08-07T16:53:28 (collector) #1][Debug] Ignoring OpenTelemetry histogram metric: 'my_histogram': Missing min value
appsignal-collector-1 | [2025-08-07T16:53:28 (collector) #1][Debug] Ignoring OpenTelemetry histogram metric: 'my_tagged_histogram': Missing min value
There was a problem hiding this comment.
Oh, thank you for spotting this! Another ✨ fun ✨ change to the histogram-to-distributions hack incoming, I guess.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, after implementing that and testing that: turns out what the PHP histogram implementation actually does is send exemplars. The bad news is now I have to implement exemplars support. The good news is that exemplars are exactly what we wish we'd get from OpenTelemetry, rather than a histogram that we need to invent plausible values for.
There was a problem hiding this comment.
Okay 👍 Is the PR you linked up-to-date then?
There was a problem hiding this comment.
That PR is fine and ready to merge IMO (I think it's an overall improvement) but there will be a second PR that actually implements what's necessary in order to support PHP histograms.
unflxw
force-pushed
the
logging-metrics-go-java-php
branch
from
bc89d89 to
d830e41
Compare
2 participants
Add endpoints that emit logs and metrics, where missing, to some of the Go, Java and PHP test setups.
This PR is a complement to the docs' PR: https://github.com/appsignal/appsignal-docs/pull/2786