Skip to content

Conversation

@lipskis
Copy link
Contributor

@lipskis lipskis commented Oct 3, 2025

Add a timeout of 10 minutes for test jobs.

Right now jobs have the default timeout, which is 360 minutes. Recently, a Node.js test job ran for 2h 20m 13s.
See https://github.com/appsignal/test-setups/actions/runs/18198404643/job/51810713493.

Most test jobs finish within 2-3 minutes, the longest being PHP tests, running for 4 minutes.

@lipskis lipskis self-assigned this Oct 3, 2025
@lipskis lipskis added the chore A small task that takes a day or two at the most. label Oct 3, 2025
Add a timeout of 10 minutes for test jobs.

Right now jobs have the default timeout, which is 360 minutes. Recently,
a Node.js test job ran for 2h 20m 13s. See
https://github.com/appsignal/test-setups/actions/runs/18198404643/job/51810713493

Most test jobs finish within 2-3 minutes, the longest being PHP tests,
running for 4 minutes.
@backlog-helper
Copy link

backlog-helper bot commented Oct 3, 2025

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

@lipskis lipskis force-pushed the set-timeout-for-actions branch from facc361 to b1af947 Compare October 3, 2025 09:43
@lipskis lipskis requested review from tombruijn and unflxw October 3, 2025 09:43
Jobs on Github actions don't have access to the `env` context, only
steps do. To avoid defining `timeout-minutes` for each step, use a yml
achor and alias. Anchors and aliases are supported starting from
September 2025.

See
https://github.blog/changelog/2025-09-18-actions-yaml-anchors-and-non-public-workflow-templates/
@lipskis
Copy link
Contributor Author

lipskis commented Oct 3, 2025

Looks like the env context isn't available in jobs. Only steps have access to the env context.

So to avoid defining timeout-minutes for each step, I'm using a YAML anchor. The support for anchors is relatively new in GitHub Actions.

Copy link
Contributor

@unflxw unflxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

It would also have been fine to repeat the job timeout for each job, in my opinion. After all, it's something we may want to tweak per job, rather than keep it the same for all jobs.

@backlog-helper
Copy link

backlog-helper bot commented Oct 6, 2025


This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

@lipskis lipskis merged commit a79e699 into main Oct 6, 2025
72 checks passed
@lipskis lipskis deleted the set-timeout-for-actions branch October 6, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A small task that takes a day or two at the most.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants