Improve rails6-shoryuken and remove shoryuken#374
Merged
Conversation
Shoryuken can deliver a group of SQS messages to a single worker `perform` call when the worker sets `:batch => true`. AppSignal instruments that batch case differently from a single message. It tags the transaction with `batch => true`, records each message's body as a separate parameter keyed by its message ID, and does not link the transaction back to an enqueuer, because a batch can mix messages from several traces. Until now that path was only exercised by the standalone ruby/shoryuken app, which is being removed. Add a native batched worker on its own queue, enqueued from a web request, so rails6-shoryuken keeps covering it.
The ruby/shoryuken app was the only setup exercising Shoryuken used natively, rather than as an Active Job queue adapter. That coverage now lives in rails6-shoryuken: PR #371 added a native worker there, and the previous commit added a batched one. So the two native paths the standalone app covered are covered again. The app was also never in the CI matrix, so it was untested surface. Its removal leaves nothing behind but a smaller maintenance footprint. The README is regenerated to drop it.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
changed the title
rails6-shoryuken and remove shoryuken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a batched Shoryuken worker to rails6-shoryuken
Shoryuken can deliver a group of SQS messages to a single worker
performcall when the worker sets:batch => true. AppSignalinstruments that batch case differently from a single message. It tags
the transaction with
batch => true, records each message's body as aseparate parameter keyed by its message ID, and does not link the
transaction back to an enqueuer, because a batch can mix messages from
several traces.
Until now that path was only exercised by the standalone ruby/shoryuken
app, which is being removed. Add a native batched worker on its own
queue, enqueued from a web request, so rails6-shoryuken keeps covering
it.
Remove the standalone Shoryuken test app
The ruby/shoryuken app was the only setup exercising Shoryuken used
natively, rather than as an Active Job queue adapter. That coverage now
lives in rails6-shoryuken: PR #371 added a native worker there, and the
previous commit added a batched one. So the two native paths the
standalone app covered are covered again.
The app was also never in the CI matrix, so it was untested surface. Its
removal leaves nothing behind but a smaller maintenance footprint. The
README is regenerated to drop it.