-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Version Control and Tagging (Packages) #2842
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Would it make sense to review this sentence here since now we also have Cloud managed-hosting so self-hosted is not mandatory? |
I was going through the page where we explain the basics of Packages and Modules, and I was wondering if we shouldn't leave a small note when we have the publish step explained saying that this is going to make the changes available for consumption so that it mentions that if the package is git connected you also need to release a new version and have a link to the Version Control and Tagging documentation page Other similar cases: In the following info box, consider if you want to clarify that the changes are applied immediately to edit mode if the app isn't git connected. It it's git connected it continues to use the previous version until is changed directly while editing the app. |
@@ -145,6 +150,8 @@ With this, you can format dates using the JS module in multiple places throughou | |||
|
|||
:::info | |||
When you update and publish a package, these modifications automatically apply in the edit mode of the app. However, the live (deployed) version of the app remains unchanged until you redeploy the app. | |||
|
|||
If the package is git-connected, it continues to use the previous version until it is changed directly while editing the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: to make it more clear that the difference of git vs. non-git is only in edit mode and that deploy mode has the same behavior no matter the git connection exists or not, what if we change the order of the text to something like:
:::info
When you update and publish a package, these modifications automatically apply in the edit mode of the app. If the package is git-connected, it continues to use the previous version until it is changed directly.
However, in both cases, the live (deployed) version of the app remains unchanged until you redeploy the app.
Description
Provide a concise summary of the changes made in this pull request
Pull request type
Check the appropriate box:
*
Documentation tickets
Link to one or more documentation tickets:
Checklist
From the below options, select the ones that are applicable: