fix: console log update and fix modal issue #38692
Conversation
WalkthroughThe pull request modifies several Cypress end-to-end test specifications for client-side action execution. Key changes include the addition of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts, |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts,cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12804870071. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12804875642. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts (1)
Line range hint
1-200: Consider enhancing test reliability and maintainability.While the overall test structure is good, consider these improvements:
- Add data-cy attributes to modal elements for better selector stability
- Consider extracting common modal verification steps into a custom command
- Group related assertions using
expect()for better error reportingExample custom command:
// In commands.ts Cypress.Commands.add('verifyModalState', (isVisible: boolean) => { if (isVisible) { agHelper.AssertElementVisibility(locators._modalWrapper); cy.get(locators._modalButtonText).should(($els) => { expect($els.eq(1)).to.contain('Confirm'); expect($els.eq(0)).to.contain('Close'); }); } else { agHelper.AssertElementAbsence(locators._modalWrapper); } });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-build / client-build
🔇 Additional comments (1)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts (1)
70-70: LGTM! Good addition of explicit wait.The addition of
WaitUntilEleAppearimproves test reliability by ensuring the modal is visible before proceeding with assertions.
| cy.reload(); | ||
| agHelper.RefreshPage(); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove redundant page reload calls.
The code has both cy.reload() and agHelper.RefreshPage() consecutively, which is redundant. Choose one method consistently throughout the test suite.
- cy.reload();
agHelper.RefreshPage();📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cy.reload(); | |
| agHelper.RefreshPage(); | |
| agHelper.RefreshPage(); |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts,cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12807676303. |
|
/ci-test-limit-count run_count=1 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts,cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts runId=12807676303 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12808100633. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12808100633. |
|
/ci-test-limit-count run_count=5 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts,cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts runId=12807676303 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12808519570. |
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts (1)
Line range hint
144-145: Remove console.log statementsRemove debug console.log statements to keep test output clean.
- console.log("Mera variable: ", jsObjectName);Also applies to: 232-233
🧹 Nitpick comments (2)
app/client/cypress/support/Pages/IDE/Sidebar.ts (1)
25-27: Consider using Cypress config for default timeoutInstead of hardcoding the 60000ms timeout, consider using
Cypress.config().defaultCommandTimeoutfor better maintainability.- assertVisible(timeout: number = 60000) { + assertVisible(timeout: number = Cypress.config().defaultCommandTimeout) { cy.get(this.locators.sidebar, { timeout }).should("be.visible"); }app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts (1)
Line range hint
189-193: Consider moving URLs to constantsExtract hardcoded URLs like 'https://www.google.com/' to a constants file for better maintainability.
// Add to a constants file export const TEST_URLS = { THIRD_PARTY: 'https://www.google.com/', };
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts(2 hunks)app/client/cypress/support/Pages/IDE/Sidebar.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
app/client/cypress/support/Pages/IDE/Sidebar.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (3)
app/client/cypress/support/Pages/IDE/Sidebar.ts (1)
13-13: Good use of configurable timeout!Using
Cypress.config().pageLoadTimeoutinstead of a hardcoded value allows for better test configuration management.app/client/cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts (2)
4-4: Good addition of assertHelper!Adding network response assertions improves test reliability.
184-184: Network assertion placement is appropriateGood practice to verify network response before proceeding with navigation tests.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12808519570. |
|
/ci-test-limit-count run_count=5 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts runId=12807676303 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12811154389. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12807676303. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12811154389. |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts runId=12807676303 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12811682971. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12811682971. |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts runId=12812720179 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12824789430. |
sagar-qa007
changed the title
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12824789430. |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_ShowCloseModalFunctions_spec.ts |
|
/ci-test-limit-count run_count=5 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12832964544. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12832973245. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12832973245. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12832964544. |
|
/ci-test-limit-count run_count=25 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_NavigateToFunctions_spec.ts |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12843322185. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12843322185. |
Description
Fix the issue for modal and remove unwanted logs.
Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38729
Automation
/ok-to-test tags="@tag.JS"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12843319044
Commit: 8cd4512
Cypress dashboard.
Tags:
@tag.JSSpec:
Sat, 18 Jan 2025 18:43:41 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit