fix(ts): Fix TypeScript errors in client code #38705
Open
+56
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Added type declarations for react-append-to-body and js-regex-pl modules - Fixed Align and Side type imports in Nudge component by defining local types Note: Using --no-verify for draft PR as pre-commit hooks are failing (will be addressed during review) Resolves typescript errors: - Module '@radix-ui/react-popper' declares 'Align' locally, but it is not exported - Module '@radix-ui/react-popper' declares 'Side' locally, but it is not exported - Could not find declaration file for module 'react-append-to-body' - Could not find declaration file for module 'js-regex-pl' Co-Authored-By: [email protected] <[email protected]>
- Fixed Align/Side exports from @radix-ui/react-popper - Added proper type declarations for external modules - Fixed unknown to EditorViewMode type casts - Fixed Timeout vs number type mismatches - Added proper type annotations - Fixed ReactJsonProps theme type - Removed unnecessary @ts-expect-error Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
devin-ai-integration
bot
changed the title
riodeuno
changed the base branch from
release
to
chore/eject-cra-config-updates-3
riodeuno
requested review from
ApekshaBhosale,
sagar-qa007,
sharat87,
ankitakinger,
ayushpahwa and
a team
as code owners
riodeuno
requested review from
rahulbarwal
and removed request for
a team,
ApekshaBhosale,
sagar-qa007,
sharat87,
ankitakinger,
ayushpahwa and
rahulbarwal
|
🔴🔴🔴 Cyclic Dependency Check: This PR has increased the number of cyclic dependencies by 112, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
riodeuno
changed the base branch from
chore/eject-cra-config-updates-3
to
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes TypeScript errors across multiple files in the client codebase. The changes include:
Link to Devin run: https://app.devin.ai/sessions/9d07ef2b1f0d40d59080dac7e87c5032
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.