-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show environment selector in view mode (EE) (#31266) #38708
fix: show environment selector in view mode (EE) (#31266) #38708
Conversation
Co-Authored-By: Rudraprasad Das <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
Closing due to inactivity. |
Hello @ayushpahwa @AnaghHegde, i was highly interested in this PR being merged, that is currently the only reason why we cannot upgrade our instance of appsmith because our teams rely on the environment selector, what is the process to help having the PR merged ? 🤔 |
@ayushpahwa @AnaghHegde sorry for this nudge, but is there a process to follow to have this PR reconsidered ? We use the env switcher in view mode extensively and on purpose, its removal is preventing us to upgrade to newer release currently :/ |
@ashit-rath @brayn003 @riteshkew can you comment here? Thanks! |
@ayushpahwa @AnaghHegde is there any update on this? |
Fix environment selector visibility in view mode for Enterprise Edition
This PR implements the environment selector visibility fix in the EE repository, following the approach from PR #3867 for consistency. The changes ensure that the environment selector is visible in view mode while maintaining proper feature flag handling and environment-specific functionality.
Changes:
Link to Devin run: https://app.devin.ai/sessions/20a62681dd254e70b6f9165d5449a9ad
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.