Draft: Dynamically generate PDB alerts#99
Open
simu wants to merge 1 commit into
Open
Conversation
simu
force-pushed
the
feat/dynamic-pdb-alerts
branch
from
7f8d92f to
076ff17
Compare
Initial draft simply generates alerts with restricted namespace selector (only namespaces which have annotation `openshift.io/cluster-monitoring=true`) if there are any `NodeForceDrain` resources deployed on the cluster. Note that this can be incorrect, if the `NodeForceDrain` resources have specific namespace selectors. Additionally, even a smarter version can be incorrect if the `NodeForceDrain` has JQ pod selector expressions.
simu
force-pushed
the
feat/dynamic-pdb-alerts
branch
from
076ff17 to
da25ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft simply generates alerts with restricted namespace selector (only namespaces which have annotation
openshift.io/cluster-monitoring=true) if there are anyNodeForceDrainresources deployed on the cluster.Note that this can be incorrect, if the
NodeForceDrainresources have specific namespace selectors. Additionally, even a smarter version can be incorrect if theNodeForceDrainhas JQ pod selector expressions.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.