feat: add hidden email input to password reset form for password manager #2415

HarshMN2345 · 2025-09-28T17:52:37Z

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

New Features
- Email is auto-populated from the URL into an off-screen hidden email field (for credential helpers); it is not submitted with the form.
- Autocomplete enabled for "New password" and "Confirm password" inputs (autocomplete="new-password").
- Password fields now accept more flexible autocomplete behavior to better support different password managers.
- No layout or navigation changes; existing password bindings and submission behavior remain unchanged.

…ger compatibility

appwrite · 2025-09-28T17:52:41Z

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL
console-cloud `688b7c18002b9b871a8f`	Ready	View Logs	Preview URL

Note

Appwrite has a Discord community with over 16 000 members.

coderabbitai · 2025-09-28T17:52:44Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

A userEmail variable is added and populated from the email URL parameter on mount. When userId and secret are present, a visually hidden email input bound to userEmail is rendered off-screen with autocomplete="username" for password managers and is excluded from form submission. Both password fields use autocomplete="new-password". In src/lib/elements/forms/inputPassword.svelte the exported prop autocomplete is changed to type boolean | string.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the primary change of adding a hidden email input to the password reset form for password managers, uses a conventional commit prefix, and remains concise without extraneous noise, making the main intent immediately clear to any reviewer scanning the commit history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-SER-153-email-prefilled-forgot-password

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8324eb5 and 563b2bd.

📒 Files selected for processing (2)

src/lib/elements/forms/inputPassword.svelte (2 hunks)
src/routes/(public)/recover/+page.svelte (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/routes/(public)/recover/+page.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: e2e

🔇 Additional comments (1)

src/lib/elements/forms/inputPassword.svelte (1)

13-54: Good handling of mixed autocomplete types.

Appreciate the union typing plus the explicit mapping to 'on'/'off', which makes the API friendlier for both boolean flags and concrete tokens like 'new-password' while keeping the DOM attribute valid.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull Request Overview

This PR adds a hidden email input field to the password reset form to improve password manager compatibility. Password managers typically need both username/email and password fields to properly detect and save credentials.

Adds a hidden email input field with proper accessibility attributes
Extracts email from URL parameters for the hidden field
Enables autocomplete on password inputs

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-28T17:55:54Z

src/routes/(public)/recover/+page.svelte

+                        autocomplete={true}
                        bind:value={password} />
                    <InputPassword
                        label="Confirm password"
                        placeholder="Confirm password"
                        id="confirm-password"
                        required={true}
+                        autocomplete={true}


The autocomplete attribute should be a string value, not a boolean. For password fields, use 'new-password' for the new password field to indicate this is a password creation scenario.

Suggested change

autocomplete={true}

bind:value={password} />

<InputPassword

label="Confirm password"

placeholder="Confirm password"

id="confirm-password"

required={true}

autocomplete={true}

autocomplete="new-password"

bind:value={password} />

<InputPassword

label="Confirm password"

placeholder="Confirm password"

id="confirm-password"

required={true}

autocomplete="new-password"

src/routes/(public)/recover/+page.svelte

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e3b6c5 and cfbde63.

📒 Files selected for processing (1)

src/routes/(public)/recover/+page.svelte (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: e2e
GitHub Check: build

src/routes/(public)/recover/+page.svelte

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-28T18:13:46Z

src/routes/(public)/recover/+page.svelte

+                    <input
+                        type="email"
+                        name="email"
+                        value={userEmail}
+                        style="position: absolute; left: -9999px; opacity: 0; pointer-events: none;"
+                        tabindex="-1"
+                        autocomplete="username"
+                        aria-hidden="true" />


[nitpick] Using inline styles for hiding elements is not recommended. Consider using CSS classes or data attributes for better maintainability and consistency with the project's styling approach.

Copilot · 2025-09-28T18:13:46Z

src/lib/elements/forms/inputPassword.svelte

    autofocus={autofocus || undefined}
-    autocomplete={autocomplete ? 'on' : 'off'}
+    autocomplete={typeof autocomplete === 'string'
+        ? (autocomplete as HTMLInputElement['autocomplete'])


[nitpick] The type assertion as HTMLInputElement['autocomplete'] is unnecessary since TypeScript can infer the type when autocomplete is a string. Consider removing the type assertion for cleaner code.

Suggested change

? (autocomplete as HTMLInputElement['autocomplete'])

? autocomplete

feat: add hidden email input to password reset form for password mana…

cfbde63

…ger compatibility

HarshMN2345 requested a review from ItzNotABug September 28, 2025 17:52

HarshMN2345 changed the title ~~feat: add hidden email input to password reset form for password mana…~~ feat: add hidden email input to password reset form for password manager Sep 28, 2025

HarshMN2345 requested a review from Copilot September 28, 2025 17:55

Copilot AI reviewed Sep 28, 2025

View reviewed changes

HarshMN2345 removed the request for review from ItzNotABug September 28, 2025 17:56

coderabbitai bot reviewed Sep 28, 2025

View reviewed changes

src/routes/(public)/recover/+page.svelte Outdated Show resolved Hide resolved

fix using string

563b2bd

HarshMN2345 force-pushed the fix-SER-153-email-prefilled-forgot-password branch from 8324eb5 to 563b2bd Compare September 28, 2025 18:10

HarshMN2345 requested a review from Copilot September 28, 2025 18:13

Copilot AI reviewed Sep 28, 2025

View reviewed changes

HarshMN2345 requested a review from ItzNotABug September 29, 2025 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add hidden email input to password reset form for password manager #2415

feat: add hidden email input to password reset form for password manager #2415

Uh oh!

HarshMN2345 commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

appwrite bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	? (autocomplete as HTMLInputElement['autocomplete'])
	? autocomplete

feat: add hidden email input to password reset form for password manager #2415

Are you sure you want to change the base?

feat: add hidden email input to password reset form for password manager #2415

Uh oh!

Conversation

HarshMN2345 commented Sep 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Summary by CodeRabbit

Uh oh!

appwrite bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Console

Uh oh!

coderabbitai bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

HarshMN2345 commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

appwrite bot commented Sep 28, 2025 •

edited

Loading

coderabbitai bot commented Sep 28, 2025 •

edited

Loading