1.6.x #34
Merged
1.6.x #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
reviewed
Aug 24, 2024
Comment on lines
+76
to
+79
| $apiParams['userId'] = $userId; | ||
| $apiParams['email'] = $email; | ||
| $apiParams['password'] = $password; | ||
|
|
There was a problem hiding this comment.
just curious as to why don't we throw the error beforehand now?
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
Why is the file name create-j-w-t.md?
Shouldn't it be create-jwt.md?
| @@ -5,8 +5,8 @@ use Appwrite\Services\Users; | |||
|
|
|||
| $client = (new Client()) | |||
| ->setEndpoint('https://cloud.appwrite.io/v1') // Your API Endpoint | |||
There was a problem hiding this comment.
Here as well. Shouldn't it be create-md5user.md?
| @@ -38,6 +38,7 @@ POST https://cloud.appwrite.io/v1/functions | |||
| | logging | boolean | Whether executions will be logged. When set to false, executions will not be logged, but will reduce resource used by your Appwrite project. | 1 | | |||
| | entrypoint | string | Entrypoint File. This path is relative to the "providerRootDirectory". | | | |||
| | commands | string | Build Commands. | | | |||
| | scopes | array | List of scopes allowed for API key auto-generated for every execution. Maximum of 100 scopes are allowed. | [] | | |||
There was a problem hiding this comment.
Suggested change
| | scopes | array | List of scopes allowed for API key auto-generated for every execution. Maximum of 100 scopes are allowed. | [] | | |
| | scopes | array | List of scopes allowed for API key auto-generation for every execution. Maximum of 100 scopes are allowed. | [] | |
There was a problem hiding this comment.
Or maybe auto-generated API key
| @@ -93,11 +135,13 @@ PUT https://cloud.appwrite.io/v1/functions/{functionId} | |||
| | logging | boolean | Whether executions will be logged. When set to false, executions will not be logged, but will reduce resource used by your Appwrite project. | 1 | | |||
| | entrypoint | string | Entrypoint File. This path is relative to the "providerRootDirectory". | | | |||
| | commands | string | Build Commands. | | | |||
| | scopes | array | List of scopes allowed for API Key auto-generated for every execution. Maximum of 100 scopes are allowed. | [] | | |||
| @@ -32,7 +32,7 @@ POST https://cloud.appwrite.io/v1/storage/buckets | |||
| | permissions | array | An array of permission strings. By default, no user is granted with any permissions. [Learn more about permissions](https://appwrite.io/docs/permissions). | | | |||
| | fileSecurity | boolean | Enables configuring permissions for individual file. A user needs one of file or bucket level permissions to access a file. [Learn more about permissions](https://appwrite.io/docs/permissions). | | | |||
| | enabled | boolean | Is bucket enabled? When set to 'disabled', users cannot access the files in this bucket but Server SDKs with and API key can still access the bucket. No files are lost when this is toggled. | 1 | | |||
| | maximumFileSize | integer | Maximum file size allowed in bytes. Maximum allowed value is 30MB. | 30000000 | | |||
| | maximumFileSize | integer | Maximum file size allowed in bytes. Maximum allowed value is 30MB. | [] | | |||
There was a problem hiding this comment.
Here it mentions default value of integer is []. Looks like the type didn't get rendered properly.
Meldiron
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)