Skip to content

fix(js): add fallback enum key when unicode values produce empty identifier #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adwaith-Jayan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(js): add fallback enum key when unicode values produce empty identifier #1358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1dd2c7
fix(js): add fallback enum key when generated identifier is empty for…
Adwaith-Jayan Feb 19, 2026
1f5d4d1
fix(js): escape enum values and use safer fallback prefix
Adwaith-Jayan Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/web/src/enums/enum.ts.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export enum {{ enum.name | caseUcfirst }} {
{% for value in enum.enum %}
{% set key = enum.keys is empty ? value : enum.keys[loop.index0] %}
{{ key | replace({'-': ''}) | caseEnumKey }} = '{{ value }}',
{% set processed = key | replace({'-': ''}) | caseEnumKey %}
{{ processed is empty ? '_Value' ~ loop.index0 : processed }} = '{{ value | e('js') }}',
{% endfor %}
}
Loading