feat: update solid example to use switch/match and get account on page load #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e load This commit updates the SolidJS example in the quickstart to: - Use the `<Switch>/<Match>` syntax instead of `if...else` conditionals - Gets the account when the page loads (in case a user is signed in already)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit updates the SolidJS example in the quickstart to:
<Switch>/<Match>syntax instead ofif...elseconditionalsTest Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
I do not think any tests are required; I have verified that this works
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
I cannot find any issues relating to this particular example in the quickstart
Have you read the Contributing Guidelines on issues?
Yes (all relevant parts).