Add Team invites doc and user journey #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
requested changes
Jan 14, 2025
eldadfux
reviewed
Jan 27, 2025
| @@ -96,6 +96,10 @@ | |||
| { | |||
| label: 'Verify user', | |||
| href: '/docs/products/auth/verify-user' | |||
| }, | |||
| { | |||
| label: 'Manage team invites', | |||
There was a problem hiding this comment.
Suggested change
| label: 'Manage team invites', | |
| label: 'Manage team invites', |
Navigation labels should focus on nouns rather than verbs to maintain a consistent style. This ensures that all items in the navigation menu have the same tone and structure, making them easier to scan and understand quickly. For example, instead of “Manage team invites,” we would simply use “Team invites.”
By avoiding verbs like “Manage,” we eliminate the need to prefix every label with an action.
There was a problem hiding this comment.
On that note, we should probably also change Verify user to User verification
There was a problem hiding this comment.
Changing this back. I initially used "Team invites" but just updated it from a review above
stnguyen90
requested changes
Feb 20, 2025
stnguyen90
requested changes
Mar 4, 2025
Co-authored-by: Steven Nguyen <[email protected]>
Co-authored-by: Steven Nguyen <[email protected]>
stnguyen90
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds team invites doc and user journey
Test plan
/docs/products/auth/team-invitesRelated
DRL-1114