Skip to content

feat(api): add NumPackages to mirrors/repos/snapshots list responses#1559

Merged
neolynx merged 3 commits into
aptly-dev:masterfrom
linuxdataflow:feat/pls/api-package-count
Apr 26, 2026
Merged

feat(api): add NumPackages to mirrors/repos/snapshots list responses#1559
neolynx merged 3 commits into
aptly-dev:masterfrom
linuxdataflow:feat/pls/api-package-count

Conversation

@lesaux

@lesaux lesaux commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Description of the Change

add API response wrappers with NumPackages derived from RefList length; keep show endpoint payloads unchanged for backward compatibility; add API tests for list endpoint NumPackages; update swagger response schemas for list endpoints

Checklist

  • allow Maintainers to edit PR (rebase, run coverage, help with tests, ...)
  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.91%. Comparing base (f8620d1) to head (0b84009).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
api/mirror.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
- Coverage   77.18%   76.91%   -0.28%     
==========================================
  Files         160      161       +1     
  Lines       15058    15080      +22     
==========================================
- Hits        11623    11599      -24     
- Misses       2291     2342      +51     
+ Partials     1144     1139       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx neolynx requested a review from a team April 12, 2026 19:38
@neolynx neolynx self-assigned this Apr 12, 2026
@neolynx neolynx added needs rebase The PR needs to be rebased on master needs maintainer access and removed needs maintainer access labels Apr 12, 2026
@neolynx neolynx force-pushed the feat/pls/api-package-count branch from c370a48 to 12fdee0 Compare April 26, 2026 15:07
@neolynx neolynx added needs review Ready for review & merge and removed needs rebase The PR needs to be rebased on master labels Apr 26, 2026
@neolynx neolynx force-pushed the feat/pls/api-package-count branch from 12fdee0 to a0e2414 Compare April 26, 2026 15:47
lesaux and others added 3 commits April 26, 2026 18:37
add API response wrappers with NumPackages derived from RefList length; keep show endpoint payloads unchanged for backward compatibility; add API tests for list endpoint NumPackages; update swagger response schemas for list endpoints
@neolynx neolynx force-pushed the feat/pls/api-package-count branch from 3f56e9c to 0b84009 Compare April 26, 2026 16:38

@neolynx neolynx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

@neolynx neolynx merged commit 809ab47 into aptly-dev:master Apr 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Ready for review & merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants