This repository was archived by the owner on Jul 30, 2025. It is now read-only.
generating test transactions with move script#775
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
f346475 to
337099f
Compare
yuunlimm
requested review from
a team,
gregnazario,
hariria and
igor-p
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
This was referenced Jan 17, 2025
Merged
gregnazario
reviewed
Jan 22, 2025
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
337099f to
41c221f
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
d35779c to
18f5a07
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
41c221f to
f4a5496
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
18f5a07 to
e3a6dae
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
f4a5496 to
7c9ef01
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
e3a6dae to
51b360e
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
7c9ef01 to
443f3c1
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
51b360e to
0307421
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
443f3c1 to
719d843
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
0307421 to
d1e31ef
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
719d843 to
fc57bc1
Compare
rtso
reviewed
Jan 23, 2025
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-script.mdx
Outdated
Show resolved
Hide resolved
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
fc57bc1 to
ee03a7e
Compare
|
|
||
|
|
||
| ## Next Steps | ||
| Once the transaction constants are integrated, you can use them in processor tests to validate functionality. For detailed instructions on writing processor tests, refer to [Writing Processor Tests](). No newline at end of file |
Contributor
There was a problem hiding this comment.
The empty link [Writing Processor Tests]() will be broken when rendered. Please either add the correct URL path to the parentheses or remove the Markdown link formatting if the destination page doesn't exist yet.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| 1. Read the configuration in the `move_fixtures` folder. | ||
| 2. Execute the specified Move scripts. | ||
| 3. Output the generated JSON files to the designated folder (`~/aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/json_transactions`). |
Contributor
There was a problem hiding this comment.
The output path shown in the documentation (~/aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/json_transactions) differs from the path specified in the command (../indexer-test-transactions/src/). This discrepancy should be resolved to ensure users can follow the instructions correctly. Consider updating either the command or the documentation to show the correct output path.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
rtso
reviewed
Jan 27, 2025
| ### Set up `move_fixtures` folder | ||
| Before proceeding, ensure you have the move_fixtures folder set up in the appropriate location: | ||
| 1. Location: | ||
| The move_fixtures folder should be created in the `aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/imported_transactions` directory. This is the folder where Move scripts and their configurations for test transactions will be stored. |
Contributor
There was a problem hiding this comment.
Suggested change
| The move_fixtures folder should be created in the `aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/imported_transactions` directory. This is the folder where Move scripts and their configurations for test transactions will be stored. | |
| The `move_fixtures` folder should be created in the `aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/imported_transactions` directory. This is the folder where Move scripts and their configurations for test transactions will be stored. |
| 1. Location: | ||
| The move_fixtures folder should be created in the `aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/imported_transactions` directory. This is the folder where Move scripts and their configurations for test transactions will be stored. | ||
|
|
||
| <Callout> **Note:** Do not create the `move_fixtures` folder in your processor repository. All Move-related files should reside in the `aptos-core` repository under the specified directory. </Callout> |
Contributor
There was a problem hiding this comment.
why can't you put move_fixtures in the processor repository? what if they want to add the fixtures to version control?
rtso
reviewed
Jan 27, 2025
| ### Set Up Test Accounts | ||
|
|
||
| 1. These accounts will be used to deploy your module. | ||
| 2. Set up as many accounts as you need. These accounts will be used to send the scripted transactions. Refer to the guide [here](https://aptos.dev/en/build/cli/setup-cli) to create accounts. |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. Set up as many accounts as you need. These accounts will be used to send the scripted transactions. Refer to the guide [here](https://aptos.dev/en/build/cli/setup-cli) to create accounts. | |
| 2. Set up as many accounts as you need. These accounts will be used to send the scripted transactions. Refer to [Aptos CLI](https://aptos.dev/en/build/cli/setup-cli) to create accounts. |
|
|
||
| ## Overview: | ||
|
|
||
| This section outlines how to create test transactions with Move scripts. |
Contributor
There was a problem hiding this comment.
i think it'd help to have details on why you need scripted txn's, and when you would use a scripted txn instead of an imported txn
Comment on lines
+90
to
+92
| - **Add as a Dependency**: | ||
|
|
||
| Include the crate containing the generated transactions as a dependency in the `Cargo.toml` file of your test crate. (Internally, transactions are stored in `aptos-core` and used in the [processor repo](https://github.com/aptos-labs/aptos-indexer-processors/blob/0c92d323b0f560b5f8601a831a36520ad9b72d68/rust/Cargo.toml#L34)). |
Contributor
There was a problem hiding this comment.
not needed as per discussion on previous PR
|
|
||
| ```bash | ||
| cd ~/aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator | ||
| cargo run -- --testing-folder ./imported_transactions --output-folder ../indexer-test-transactions/src/ |
Contributor
There was a problem hiding this comment.
Suggested change
| cargo run -- --testing-folder ./imported_transactions --output-folder ../indexer-test-transactions/src/ | |
| cargo run -- --testing-folder ./imported_transactions --output-folder /path/to/processor/repo/ |
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
60db79c to
e8f5eaf
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
260f684 to
95c1024
Compare
yuunlimm
force-pushed
the
01-17-importing_test_transactions
branch
from
e8f5eaf to
775613a
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
95c1024 to
d958d58
Compare
| The move_fixtures folder should be created in the `aptos-core/ecosystem/indexer-grpc/indexer-transaction-generator/imported_transactions` directory. This is the folder where Move scripts and their configurations for test transactions will be stored. | ||
|
|
||
| <Callout> **Note:** Do not create the `move_fixtures` folder in your processor repository. All Move-related files should reside in the `aptos-core` repository under the specified directory. </Callout> | ||
| 2. Steps to set up the follder: |
Contributor
There was a problem hiding this comment.
Typo: follder -> folder
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
|
|
||
| ## Next Steps | ||
| Once the transaction constants are integrated, you can use them in processor tests to validate functionality. For detailed instructions on writing processor tests, refer to [Writing Processor Tests](). No newline at end of file |
Contributor
There was a problem hiding this comment.
The link [Writing Processor Tests]() appears to be a placeholder without a destination URL. Consider either adding the correct documentation URL or removing the link formatting until the documentation is available. This will prevent broken links in the published documentation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
yuunlimm
changed the base branch from
01-17-importing_test_transactions
to
graphite-base/775
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
d958d58 to
72c37ec
Compare
yuunlimm
force-pushed
the
graphite-base/775
branch
from
775613a to
475d800
Compare
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
72c37ec to
8313ef5
Compare
hariria
reviewed
Feb 8, 2025
| @@ -0,0 +1,102 @@ | |||
| --- | |||
| title: "Aptos Transaction generated using Move Script" | |||
Collaborator
There was a problem hiding this comment.
I think it might be good to make the title of this consistent with the sidebar title you have in _meta.tsx
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
8313ef5 to
9d90f22
Compare
| The configuration file should be structured like this: | ||
| - output_name: This field specifies the name of the output file where the results of the transaction will be saved. | ||
| - script_path: This field holds the path to the Move script file that will be executed as part of the transaction. | ||
| - sender_address: : This field contains the address of the account that will send the transaction. |
Contributor
There was a problem hiding this comment.
There is a duplicate colon in sender_address: : - one colon is sufficient here.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| ### Export the `json_transactions` Folder | ||
|
|
||
| Since the `generated_transactions.rs` relies on the `json_transactions` Ensure the `json_transactions` folder is properly exported in the library file for your tests have direct access to the transaction data. |
Contributor
There was a problem hiding this comment.
Missing comma after "json_transactions" in this sentence. The corrected version should read: "Since the generated_transactions.rs relies on the json_transactions, ensure..."
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| The configuration file should be structured like this: | ||
| - output_name: This field specifies the name of the output file where the results of the transaction will be saved. | ||
| - script_path: This field holds the path to the Move script file that will be executed as part of the transaction. | ||
| - sender_address: : This field contains the address of the account that will send the transaction. |
Contributor
There was a problem hiding this comment.
There is a duplicate colon in sender_address: : - this should be sender_address:
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
yuunlimm
force-pushed
the
01-17-generating_test_transactions_with_move_script
branch
from
c5cd27a to
0de5f57
Compare
rtso
reviewed
Apr 1, 2025
| - import | ||
| - script | ||
|
|
||
| 4. `--network` |
Contributor
There was a problem hiding this comment.
isn't the network to get txn's from already in the config.yaml file?
rtso
approved these changes
Apr 1, 2025
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm fmt?pnpm lint?