This repository was archived by the owner on Jul 30, 2025. It is now read-only.
fix: Improve OpenSSL version detection error handling in CLI installer#821
Closed
VolodymyrBg wants to merge 2 commits intoaptos-labs:mainfrom
Closed
fix: Improve OpenSSL version detection error handling in CLI installer#821VolodymyrBg wants to merge 2 commits intoaptos-labs:mainfrom
VolodymyrBg wants to merge 2 commits intoaptos-labs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gregnazario
approved these changes
Feb 18, 2025
Collaborator
gregnazario
left a comment
gregnazario
left a comment
There was a problem hiding this comment.
Were you able to test this accordingly?
Hopefully people are not using 1.x.x anymore
Contributor
Author
|
@gregnazario Done |
Collaborator
@banool second eyes on this? |
Contributor
Author
Collaborator
|
This PR #840 is basically the changes that need to happen, since 20.04 is being deprecated |
Contributor
Author
|
@gregnazario so this one is going to be closed? |
Collaborator
Yes, but thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved error handling in OpenSSL version detection for CLI installer
This PR enhances the error handling when detecting OpenSSL version during CLI installation. The changes include:
These changes will help users better understand installation issues related to OpenSSL version detection and make troubleshooting easier.
Checklist
pnpm fmt?pnpm lint?