Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

[indexer] Update deprecated tables#933

Merged
rtso merged 1 commit intomainfrom
05-07-deprecation
May 7, 2025
Merged

[indexer] Update deprecated tables#933
rtso merged 1 commit intomainfrom
05-07-deprecation

Conversation

@rtso
Copy link
Contributor

@rtso rtso commented May 7, 2025

Description

Screenshot 2025-05-07 at 4 22 49 PM

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

@vercel
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 8:53pm

Copy link
Contributor Author

rtso commented May 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rtso rtso changed the title deprecation [indexer] Update deprecated tables May 7, 2025
@rtso rtso requested review from a team and yuunlimm May 7, 2025 19:39
@rtso rtso marked this pull request as ready for review May 7, 2025 19:39
Copilot AI review requested due to automatic review settings May 7, 2025 19:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the indexer deprecated tables documentation by removing the old table with deprecation dates and replacing it with a simplified table containing the current table names and their replacement notes.

  • Removed detailed deprecation date columns for legacy tables.
  • Added a new, concise table listing tables and their corresponding replacement or guidance notes.

Copy link

@jtang17 jtang17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a menu item (sidebar) that links to Deprecated Tables?

@rtso
Copy link
Contributor Author

rtso commented May 7, 2025

@jtang17 added!

Copy link
Contributor

@ying-w ying-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're removing all of the raw data tables (events, transactions, signatures, resources) do you want to mention for these that non-real time is available on bigquery

| coin_activities | Replace with fungible_asset_activities |
| coin_balances | Replace with current_fungible_asset_balances |
| coin_infos | Replace with fungible_asset_metadata |
| coin_supply | No replacement|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you if you want to include it but i've replicated the logic here https://github.com/aptos-labs/explorer/blob/main/analytics/apt_supply.sql

Copy link
Contributor Author

rtso commented May 7, 2025

Sure I can add that

@rtso rtso force-pushed the 05-07-deprecation branch from 6f713a6 to 757502f Compare May 7, 2025 20:50
@rtso rtso merged commit 94cef16 into main May 7, 2025
4 of 5 checks passed
@rtso rtso deleted the 05-07-deprecation branch May 7, 2025 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants