Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

cannot request to fund 0 amount#941

Merged
0x-j merged 2 commits intomainfrom
j/fix-first-tx-example
May 12, 2025
Merged

cannot request to fund 0 amount#941
0x-j merged 2 commits intomainfrom
j/fix-first-tx-example

Conversation

@0x-j
Copy link
Contributor

@0x-j 0x-j commented May 12, 2025

Description

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copilot AI review requested due to automatic review settings May 12, 2025 01:34
@0x-j 0x-j requested review from gregnazario and hariria as code owners May 12, 2025 01:34
@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 7:29pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes examples that fund an account with 0 amount, aligning the code samples with the new restriction that 0 funding is not allowed.

  • Removed a JavaScript funding call for Bob's account with an amount of 0 APT.
  • Removed a Python funding call for Bob's address with a value of 0.
Comments suppressed due to low confidence (2)

apps/nextra/pages/en/build/guides/first-transaction.mdx:194

  • Removing the funding call with 0 APT for Bob is in line with the new restrictions but consider adding a brief comment explaining why this call is omitted for clarity.
await aptos.fundAccount({

apps/nextra/pages/en/build/guides/first-transaction.mdx:309

  • The removal of the funding call for Bob in the Python example is appropriate. A comment may help guide readers regarding the exclusion of a 0 funding amount.
await faucet_client.fund_account(bob.address(), bob_amount)

Co-authored-by: Maayan <maayan@aptoslabs.com>
@0x-j 0x-j enabled auto-merge (squash) May 12, 2025 19:21
@0x-j 0x-j merged commit 8fa630a into main May 12, 2025
6 checks passed
@0x-j 0x-j deleted the j/fix-first-tx-example branch May 12, 2025 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants