This repository was archived by the owner on Jul 30, 2025. It is now read-only.
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes examples that fund an account with 0 amount, aligning the code samples with the new restriction that 0 funding is not allowed.
- Removed a JavaScript funding call for Bob's account with an amount of 0 APT.
- Removed a Python funding call for Bob's address with a value of 0.
Comments suppressed due to low confidence (2)
apps/nextra/pages/en/build/guides/first-transaction.mdx:194
- Removing the funding call with 0 APT for Bob is in line with the new restrictions but consider adding a brief comment explaining why this call is omitted for clarity.
await aptos.fundAccount({
apps/nextra/pages/en/build/guides/first-transaction.mdx:309
- The removal of the funding call for Bob in the Python example is appropriate. A comment may help guide readers regarding the exclusion of a 0 funding amount.
await faucet_client.fund_account(bob.address(), bob_amount)
0xmaayan
reviewed
May 12, 2025
0xmaayan
approved these changes
May 12, 2025
Co-authored-by: Maayan <maayan@aptoslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm fmt?pnpm lint?