fix(modules): clarify Run simulate API auth errors#1655
Draft
WGB5445 wants to merge 1 commit into
Draft
Conversation
When Simulate hits Aptos API gateway 401/429 responses, show actionable copy and link to Settings instead of raw SDK error text. Fixes #1654 Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle ReportChanges will increase total bundle size by 2.87kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: aptos-explorer-server-esmAssets Changed:
Files in
view changes for bundle: aptos-explorer-client-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 31.97% 32.08% +0.11%
==========================================
Files 182 183 +1
Lines 8561 8579 +18
Branches 3215 3226 +11
==========================================
+ Hits 2737 2753 +16
- Misses 5820 5822 +2
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gregnazario
reviewed
May 26, 2026
Comment on lines
+1067
to
+1079
| {simulationError.suggestSettings && ( | ||
| <Typography | ||
| variant="body2" | ||
| sx={{ | ||
| color: "text.secondary", | ||
| mt: 1, | ||
| }} | ||
| > | ||
| Check <Link to="/settings">API keys in Settings</Link>. | ||
| An invalid or expired mainnet override replaces the | ||
| built-in key used for simulation. | ||
| </Typography> | ||
| )} |
Contributor
There was a problem hiding this comment.
This only makes sense if the API key is overridden, maybe we should check that state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
On explorer.aptoslabs.com (mainnet), the account Modules → Run tab Simulate button can fail with HTTP 401 from the Aptos fullnode:
This is an API Gateway authentication / per-IP policy response—not a Move VM simulation failure.
Why Write can still work: Simulate uses Explorer’s browser
sdkV2Client(getApiKey()→Authorization: Bearer …onapi.mainnet.aptoslabs.com). Write uses the connected wallet’ssignAndSubmitTransactionand the wallet’s own mainnet RPC, so wallet submit can succeed while Simulate fails.Common causes: invalid Settings → API Keys mainnet override (replaces the built-in key), missing
Authorizationon the simulate request, or gateway per-IP rules for the application client ID.Covers FEAT-MODULES-001 (Run sub-tab).
What changed
formatAptosApiErrorForDisplay()(app/utils/aptosApiErrorMessage.ts) to detect HTTP 401 / 429 (and related gateway copy) and return user-facing text that distinguishes API access failures from Move execution errors.Contract.tsx): on simulate failure, show the friendly message and, when appropriate, a link to Settings → API keys.Links
Fixes #1654
Fixes DVR-161
Test plan
pnpm test --run app/utils/aptosApiErrorMessage.test.tspnpm lint