Stop the timeout if the window is not focused#112
Open
DieterHolvoet wants to merge 2 commits into
Open
Conversation
DieterHolvoet
added a commit
to DieterHolvoet/toastify-js
that referenced
this pull request
Dec 11, 2022
DieterHolvoet
added a commit
to DieterHolvoet/toastify-js
that referenced
this pull request
Dec 11, 2022
DieterHolvoet
added a commit
to DieterHolvoet/toastify-js
that referenced
this pull request
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110. This adds a new option,
stopOnWindowBlur, that - similarly to thestopOnFocusoption - stops the timeout timer if the user navigates away from the page and restarts the timer once the window regains focus. This prevents notifications from disappearing without the user actually having seen it. I set it to be enabled by default.