Skip to content

chore: load checks from repo#114

Merged
simar7 merged 1 commit intoaquasecurity:mainfrom
nikpivkin:checks-fs
Mar 12, 2025
Merged

chore: load checks from repo#114
simar7 merged 1 commit intoaquasecurity:mainfrom
nikpivkin:checks-fs

Conversation

@nikpivkin
Copy link
Copy Markdown
Contributor

This PR changes the source of the checks, replacing the checks embedded in Trivy with the trivy-checks repository, which is pulled each time a site is built. This will keep the checks documentation up to date regardless of the version of Trivy.

@nikpivkin nikpivkin requested a review from simar7 January 31, 2025 14:11
@nikpivkin nikpivkin force-pushed the checks-fs branch 3 times, most recently from eda1af0 to bb6aa90 Compare January 31, 2025 16:46
@nikpivkin nikpivkin marked this pull request as draft January 31, 2025 19:04
@simar7
Copy link
Copy Markdown
Member

simar7 commented Feb 7, 2025

lgtm, could you rebase and mark for review if ready?

@nikpivkin
Copy link
Copy Markdown
Contributor Author

@simar7 I was thinking that maybe we should still load checks from trivy or at least trivy-checks? If we add a new check but don't release a new bundle, it will be on the web site but not available to users. In this repository we can set up dependabot to update dependencies in a timely manner.

@simar7
Copy link
Copy Markdown
Member

simar7 commented Feb 20, 2025

@simar7 I was thinking that maybe we should still load checks from trivy or at least trivy-checks? If we add a new check but don't release a new bundle, it will be on the web site but not available to users. In this repository we can set up dependabot to update dependencies in a timely manner.

On the contrary, if we still load checks from releases we still have the wait until the next release takes place. Sometimes we just want to have a page in AVD and not wait until the next trivy (or checks) release. Loading directly bypasses this wait time for AVD.

I don't think it's a big deal if we have a page on AVD that isn't yet released via Trivy. Users find AVD pages via Trivy not the other way around today.

Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review February 24, 2025 06:52
@simar7 simar7 merged commit c4b54da into aquasecurity:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants