Skip to content

Add GCR compatibility - #1199

Open
nekwar wants to merge 2 commits into
aquasecurity:mainfrom
nekwar:main
Open

Add GCR compatibility#1199
nekwar wants to merge 2 commits into
aquasecurity:mainfrom
nekwar:main

Conversation

@nekwar

@nekwar nekwar commented May 23, 2022

Copy link
Copy Markdown

Description

This PR includes GCR compatibility for Starboard operator. Basically, what you need to do to make Trivy scan images from GCR is to add GOOGLE_APPLICATION_CREDENTIALS environment variable with value that equals to path to Service Account json file. With this changes you can easily make vulnerability scan jobs actually scan images from GCR.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nekwar
nekwar marked this pull request as ready for review May 23, 2022 17:55
@CLAassistant

CLAassistant commented May 23, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@chen-keinan

Copy link
Copy Markdown
Contributor

@nekwar its look like a very nice contribution however , starboard has been migrated to trivy-operator and it is no longer maintained.
it will be great if you could make this contribution to trivy-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants